1
1
mirror of https://github.com/theoludwig/eslint-config-conventions.git synced 2025-11-01 00:52:26 +01:00

Compare commits

...

13 Commits

Author SHA1 Message Date
ede428ba5f ci: pin GitHub Actions by commit-hash
Ref: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
2025-11-01 00:51:39 +01:00
977745dabb fix: update .oxlintrc.json 2025-10-26 15:37:34 +01:00
54392498cf feat: support eslint-plugin-unicorn@^62.0.0 2025-10-26 15:32:53 +01:00
e59d48f713 build(deps): update latest 2025-10-08 17:00:11 +02:00
b2f5a136f9 fix(oxlint): relax unicorn/no-array-sort 2025-10-04 19:17:18 +02:00
fa724b4f97 fix(oxlint): relax import-x/no-named-as-default-member 2025-10-04 19:16:10 +02:00
1b70b62de1 fix(oxlint): relax import-x/no-unassigned-import 2025-09-26 19:59:58 +02:00
09493ef433 fix(oxlint): relax @typescript-eslint/no-unsafe-type-assertion 2025-09-25 07:59:20 +02:00
a13aeadda8 fix(oxlint): enable back import rules
Ref: https://github.com/oxc-project/oxc/pull/14049
2025-09-25 07:58:02 +02:00
5817503919 fix: update .oxlintrc.json 2025-09-11 21:06:08 +02:00
23bb31949d fix: relax @typescript-eslint/no-dynamic-delete 2025-09-11 21:00:36 +02:00
911fadcf02 fix: relax @typescript-eslint/no-unnecessary-type-conversion 2025-09-11 20:57:39 +02:00
2d8260472a fix!: usage of eslint defineConfig()
Ref: https://typescript-eslint.io/packages/typescript-eslint/#migrating-to-defineconfig

BREAKING CHANGE: peerDependencies:
`eslint@^9.22.0`
`eslint-plugin-unicorn@^61.0.0`
2025-09-11 19:48:20 +02:00
10 changed files with 1327 additions and 1209 deletions

View File

@@ -10,10 +10,10 @@ jobs:
lint: lint:
runs-on: "ubuntu-latest" runs-on: "ubuntu-latest"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"

View File

@@ -13,13 +13,13 @@ jobs:
pull-requests: "write" pull-requests: "write"
id-token: "write" id-token: "write"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
with: with:
fetch-depth: 0 fetch-depth: 0
persist-credentials: false persist-credentials: false
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"

View File

@@ -10,10 +10,10 @@ jobs:
test: test:
runs-on: "ubuntu-latest" runs-on: "ubuntu-latest"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"

View File

@@ -1,6 +1,6 @@
{ {
"$schema": "./node_modules/oxlint/configuration_schema.json", "$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["typescript", "unicorn", "react", "oxc", "promise"], "plugins": ["typescript", "unicorn", "react", "oxc", "import", "promise"],
"categories": { "categories": {
"correctness": "error", "correctness": "error",
"perf": "error", "perf": "error",
@@ -137,6 +137,7 @@
], ],
"no-useless-call": "error", "no-useless-call": "error",
"no-useless-concat": "error", "no-useless-concat": "error",
"no-useless-computed-key": "error",
"no-useless-constructor": "error", "no-useless-constructor": "error",
"no-useless-escape": "error", "no-useless-escape": "error",
"no-useless-rename": "error", "no-useless-rename": "error",
@@ -163,6 +164,7 @@
"arrow-body-style": ["error", "always"], "arrow-body-style": ["error", "always"],
"promise/param-names": "error", "promise/param-names": "error",
"promise/no-new-statics": "error", "promise/no-new-statics": "error",
"promise/no-multiple-resolved": "error",
"promise/no-nesting": "error", "promise/no-nesting": "error",
"unicorn/catch-error-name": "error", "unicorn/catch-error-name": "error",
"unicorn/consistent-date-clone": "error", "unicorn/consistent-date-clone": "error",
@@ -170,6 +172,7 @@
"unicorn/escape-case": "error", "unicorn/escape-case": "error",
"unicorn/explicit-length-check": "error", "unicorn/explicit-length-check": "error",
"unicorn/new-for-builtins": "error", "unicorn/new-for-builtins": "error",
"unicorn/no-array-callback-reference": "error",
"unicorn/no-array-for-each": "error", "unicorn/no-array-for-each": "error",
"unicorn/no-array-method-this-argument": "error", "unicorn/no-array-method-this-argument": "error",
"unicorn/no-document-cookie": "error", "unicorn/no-document-cookie": "error",
@@ -192,6 +195,8 @@
"unicorn/no-unnecessary-array-flat-depth": "error", "unicorn/no-unnecessary-array-flat-depth": "error",
"unicorn/consistent-assert": "error", "unicorn/consistent-assert": "error",
"unicorn/no-accessor-recursion": "error", "unicorn/no-accessor-recursion": "error",
"unicorn/no-array-reverse": "off",
"unicorn/no-array-sort": "off",
"react/no-array-index-key": "off", "react/no-array-index-key": "off",
"react-hooks/rules-of-hooks": "error", "react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "error", "react-hooks/exhaustive-deps": "error",
@@ -240,13 +245,24 @@
"@next/next/no-document-import-in-page": "error", "@next/next/no-document-import-in-page": "error",
"@next/next/no-duplicate-head": "error", "@next/next/no-duplicate-head": "error",
"@next/next/no-head-import-in-document": "error", "@next/next/no-head-import-in-document": "error",
"@next/next/no-script-component-in-head": "error" "@next/next/no-script-component-in-head": "error",
"import-x/no-absolute-path": "error",
"import-x/no-webpack-loader-syntax": "error",
"import-x/no-self-import": "error",
"import-x/no-duplicates": "error",
"import-x/no-named-default": "error",
"import-x/no-empty-named-blocks": "error",
"import-x/no-anonymous-default-export": "error",
"import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
"import-x/no-unassigned-import": "off",
"import-x/no-named-as-default-member": "off"
}, },
"overrides": [ "overrides": [
{ {
"files": ["**/*.ts", "**/*.tsx"], "files": ["**/*.ts", "**/*.tsx"],
"rules": { "rules": {
"@typescript-eslint/no-unnecessary-type-arguments": "off", "@typescript-eslint/no-unnecessary-type-arguments": "off",
"@typescript-eslint/no-unsafe-type-assertion": "off",
"no-unused-vars": [ "no-unused-vars": [
"error", "error",
{ {

View File

@@ -35,12 +35,12 @@ More information about **formatting rules** vs **code-quality rules** can be fou
```sh ```sh
npm install --save-dev \ npm install --save-dev \
eslint@^9.21.0 \ eslint@^9.22.0 \
eslint-plugin-promise@^7.2.1 \ eslint-plugin-promise@^7.2.1 \
eslint-plugin-unicorn@^61.0.0 \ eslint-plugin-unicorn@^62.0.0 \
eslint-plugin-import-x@^4.6.1 \ eslint-plugin-import-x@^4.6.1 \
globals@^16.0.0 \ globals@^16.0.0 \
typescript@^5.8.3 \ typescript@^5.9.3 \
typescript-eslint@^8.32.0 \ typescript-eslint@^8.32.0 \
eslint-config-conventions@latest eslint-config-conventions@latest
``` ```
@@ -62,10 +62,10 @@ Dependencies are:
#### `eslint.config.js` #### `eslint.config.js`
```js ```js
import typescriptESLint from "typescript-eslint" import { defineConfig } from "eslint/config"
import configConventions from "eslint-config-conventions" import configConventions from "eslint-config-conventions"
export default typescriptESLint.config(...configConventions, { export default defineConfig(...configConventions, {
files: ["**/*.ts", "**/*.tsx"], files: ["**/*.ts", "**/*.tsx"],
languageOptions: { languageOptions: {
parser: typescriptESLint.parser, parser: typescriptESLint.parser,

View File

@@ -1,16 +1,17 @@
import importXPlugin from "eslint-plugin-import-x"
import promise from "eslint-plugin-promise" import promise from "eslint-plugin-promise"
import unicorn from "eslint-plugin-unicorn" import unicorn from "eslint-plugin-unicorn"
import importX from "eslint-plugin-import-x" import { defineConfig } from "eslint/config"
import globals from "globals" import globals from "globals"
import typescriptESLint from "typescript-eslint" import typescriptESLint from "typescript-eslint"
export default typescriptESLint.config( export default defineConfig(
{ {
name: "eslint-config-conventions", name: "eslint-config-conventions",
plugins: { plugins: {
promise, promise,
unicorn, unicorn,
"import-x": importX, "import-x": importXPlugin,
}, },
linterOptions: { linterOptions: {
reportUnusedDisableDirectives: "error", reportUnusedDisableDirectives: "error",
@@ -349,8 +350,6 @@ export default typescriptESLint.config(
"no-useless-constructor": "off", "no-useless-constructor": "off",
"@typescript-eslint/no-useless-constructor": "error", "@typescript-eslint/no-useless-constructor": "error",
"@typescript-eslint/no-unnecessary-type-conversion": "error",
"@typescript-eslint/no-unnecessary-template-expression": "error", "@typescript-eslint/no-unnecessary-template-expression": "error",
"@typescript-eslint/adjacent-overload-signatures": "error", "@typescript-eslint/adjacent-overload-signatures": "error",
@@ -386,7 +385,6 @@ export default typescriptESLint.config(
"@typescript-eslint/no-base-to-string": "error", "@typescript-eslint/no-base-to-string": "error",
"@typescript-eslint/no-deprecated": "error", "@typescript-eslint/no-deprecated": "error",
"@typescript-eslint/no-dynamic-delete": "error",
"@typescript-eslint/no-extra-non-null-assertion": "error", "@typescript-eslint/no-extra-non-null-assertion": "error",
"@typescript-eslint/no-redundant-type-constituents": "error", "@typescript-eslint/no-redundant-type-constituents": "error",

View File

@@ -1,6 +1,6 @@
import typescriptESLint from "typescript-eslint" import { defineConfig } from "eslint/config"
import configConventions from "./eslint.config.js" import configConventions from "./eslint.config.js"
export default typescriptESLint.config(...configConventions, { export default defineConfig(...configConventions, {
ignores: ["test/fixtures/*"], ignores: ["test/fixtures/*"],
}) })

8
index.d.ts vendored
View File

@@ -1,7 +1,5 @@
import type typescriptESLint from "typescript-eslint" import type { defineConfig } from "eslint/config"
declare const eslintConfigConventions: ReturnType< declare const eslintConfig: ReturnType<typeof defineConfig>
typeof typescriptESLint.config
>
export default eslintConfigConventions export default eslintConfig

2438
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -47,9 +47,9 @@
"release": "semantic-release" "release": "semantic-release"
}, },
"peerDependencies": { "peerDependencies": {
"eslint": "^9.21.0", "eslint": "^9.22.0",
"eslint-plugin-promise": "^7.2.1", "eslint-plugin-promise": "^7.2.1",
"eslint-plugin-unicorn": "^59.0.0 || ^60.0.0 || ^61.0.0", "eslint-plugin-unicorn": "^61.0.0 || ^62.0.0",
"eslint-plugin-import-x": "^4.6.1", "eslint-plugin-import-x": "^4.6.1",
"globals": "^16.0.0", "globals": "^16.0.0",
"typescript-eslint": "^8.32.0" "typescript-eslint": "^8.32.0"
@@ -75,18 +75,18 @@
} }
}, },
"devDependencies": { "devDependencies": {
"@types/node": "24.3.1", "@types/node": "24.9.1",
"globals": "16.3.0", "globals": "16.4.0",
"editorconfig-checker": "6.1.0", "editorconfig-checker": "6.1.1",
"oxlint": "1.14.0", "oxlint": "1.24.0",
"@oxlint/migrate": "1.14.0", "@oxlint/migrate": "1.24.0",
"eslint": "9.35.0", "eslint": "9.38.0",
"eslint-plugin-promise": "7.2.1", "eslint-plugin-promise": "7.2.1",
"eslint-plugin-unicorn": "61.0.1", "eslint-plugin-unicorn": "62.0.0",
"eslint-plugin-import-x": "4.16.1", "eslint-plugin-import-x": "4.16.1",
"typescript-eslint": "8.42.0", "typescript-eslint": "8.46.2",
"prettier": "3.6.2", "prettier": "3.6.2",
"semantic-release": "24.2.7", "semantic-release": "25.0.1",
"typescript": "5.9.2" "typescript": "5.9.3"
} }
} }