2
1
mirror of https://github.com/Thream/socketio-jwt.git synced 2024-07-21 09:38:31 +02:00
socketio-jwt/PULL_REQUEST_TEMPLATE.md
2019-01-02 19:52:26 +01:00

1.3 KiB

Pull Request Report

Please include a summary of the change you made with relevant motivation and context why such change has been made. Filling sections below will allow us to get your changes reviewed and merged easier. If you feel like certain section is not applicable, feel free to delete it. Thanks for co-operation! 🙏🏼

Description

Tell us what you changed, why you did it and what additional value it will bring.

Type of change

  • Bug fix (fix to an issue)
  • New feature (changes to functionality)
  • Big change (fix or feature that would cause existing functionality to work as expected)

Testing

Please describe the tests that you ran to verify your changes. Provide any instructions that will allow us to reproduce it. Please also list any relevant details for your test configuration.

Test Configuration

  • Framework version:
  • Language version:
  • Browser version:

Additional info

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings and errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes