1
1
mirror of https://github.com/theoludwig/eslint-config-conventions.git synced 2025-09-11 23:09:27 +02:00

Compare commits

..

21 Commits

Author SHA1 Message Date
5817503919 fix: update .oxlintrc.json 2025-09-11 21:06:08 +02:00
23bb31949d fix: relax @typescript-eslint/no-dynamic-delete 2025-09-11 21:00:36 +02:00
911fadcf02 fix: relax @typescript-eslint/no-unnecessary-type-conversion 2025-09-11 20:57:39 +02:00
2d8260472a fix!: usage of eslint defineConfig()
Ref: https://typescript-eslint.io/packages/typescript-eslint/#migrating-to-defineconfig

BREAKING CHANGE: peerDependencies:
`eslint@^9.22.0`
`eslint-plugin-unicorn@^61.0.0`
2025-09-11 19:48:20 +02:00
929978af36 feat: support eslint-plugin-unicorn@^61.0.0 2025-09-08 08:27:35 +02:00
6f42dbcdbe fix: relax jsx-a11y rules in .oxlintrc.json 2025-08-28 12:41:17 +02:00
6cd0334469 fix: update .oxlintrc.json 2025-08-27 20:11:29 +02:00
a014deeed6 fix: set peerDependencies as optional 2025-08-27 20:11:14 +02:00
91b66d24cd ci: remove commitlint (not useful) 2025-07-23 12:24:20 +02:00
6a11f2dbf6 fix: relax @typescript-eslint/no-floating-promises to include more allowForKnownSafeCalls for node:test
Ref: https://github.com/typescript-eslint/typescript-eslint/issues/11372
2025-07-23 12:21:59 +02:00
2876f22947 feat: support eslint-plugin-unicorn@^60.0.0 2025-07-22 11:06:33 +02:00
910050f30d feat: export .oxlintrc.json (#7) 2025-06-10 14:13:47 +02:00
8953d875b5 style: fix prettier 2025-05-10 20:50:44 +02:00
f45ab1dcbb feat: add unicorn/no-accessor-recursion
BREAKING CHANGE: New rule introduced
2025-05-10 20:44:46 +02:00
7bbac61906 feat: add unicorn/consistent-assert
BREAKING CHANGE: New rule introduced
2025-05-10 20:43:16 +02:00
3aacbbeec4 feat: add unicorn/no-unnecessary-array-flat-depth
BREAKING CHANGE: New rule introduced
2025-05-10 20:41:18 +02:00
c4340efc6f feat: add @typescript-eslint/no-unnecessary-type-conversion
BREAKING CHANGE: New rule introduced
2025-05-10 20:40:01 +02:00
851c468748 build(deps): update peer dependencies
BREAKING CHANGE: peerDependencies:
`eslint-plugin-unicorn@^59.0.0`
`typescript-eslint@^8.32.0`
2025-05-10 20:38:17 +02:00
892a3f8302 build(deps): update latest 2025-05-10 19:37:48 +02:00
620f6ce442 build(deps): update latest 2025-05-02 19:57:03 +02:00
1000c38cb2 feat: support eslint-plugin-unicorn@^59.0.0 2025-05-02 19:55:11 +02:00
12 changed files with 1921 additions and 1063 deletions

View File

@@ -10,10 +10,10 @@ jobs:
lint:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v4.2.2"
- uses: "actions/checkout@v5.0.0"
- name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0"
uses: "actions/setup-node@v5.0.0"
with:
node-version: "lts/*"
cache: "npm"
@@ -24,10 +24,3 @@ jobs:
- run: "node --run lint:editorconfig"
- run: "node --run lint:eslint"
- run: "node --run lint:prettier"
commitlint:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v4.2.2"
- uses: "wagoid/commitlint-github-action@v6.1.2"

View File

@@ -13,13 +13,13 @@ jobs:
pull-requests: "write"
id-token: "write"
steps:
- uses: "actions/checkout@v4.2.2"
- uses: "actions/checkout@v5.0.0"
with:
fetch-depth: 0
persist-credentials: false
- name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0"
uses: "actions/setup-node@v5.0.0"
with:
node-version: "lts/*"
cache: "npm"

View File

@@ -10,10 +10,10 @@ jobs:
test:
runs-on: "ubuntu-latest"
steps:
- uses: "actions/checkout@v4.2.2"
- uses: "actions/checkout@v5.0.0"
- name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0"
uses: "actions/setup-node@v5.0.0"
with:
node-version: "lts/*"
cache: "npm"

1
.gitignore vendored
View File

@@ -27,3 +27,4 @@ npm-debug.log*
# misc
.DS_Store
*.bak

366
.oxlintrc.json Normal file
View File

@@ -0,0 +1,366 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["typescript", "unicorn", "react", "oxc", "promise"],
"categories": {
"correctness": "error",
"perf": "error",
"suspicious": "error"
},
"env": {
"builtin": true,
"browser": true,
"node": true,
"shared-node-browser": true
},
"rules": {
"no-await-in-loop": "off",
"for-direction": "error",
"no-async-promise-executor": "error",
"no-class-assign": "error",
"no-compare-neg-zero": "error",
"no-cond-assign": "error",
"no-const-assign": "error",
"no-constant-binary-expression": "error",
"no-constant-condition": "error",
"no-constructor-return": "error",
"no-control-regex": "error",
"no-debugger": "error",
"no-dupe-class-members": "error",
"no-dupe-else-if": "error",
"no-dupe-keys": "error",
"no-duplicate-case": "error",
"no-duplicate-imports": "error",
"no-empty-character-class": "error",
"no-empty-pattern": "error",
"no-ex-assign": "error",
"no-fallthrough": "error",
"no-func-assign": "error",
"no-import-assign": "error",
"no-invalid-regexp": "error",
"no-irregular-whitespace": "error",
"no-loss-of-precision": "error",
"no-new-native-nonconstructor": "error",
"no-obj-calls": "error",
"no-prototype-builtins": "error",
"no-self-assign": "error",
"no-self-compare": "error",
"no-setter-return": "error",
"no-sparse-arrays": "error",
"no-this-before-super": "error",
"no-unexpected-multiline": "error",
"no-unsafe-finally": "error",
"no-unsafe-negation": "error",
"no-unsafe-optional-chaining": "error",
"no-unused-private-class-members": "error",
"no-unused-vars": [
"error",
{
"args": "all",
"argsIgnorePattern": "^_",
"caughtErrors": "all",
"caughtErrorsIgnorePattern": "^_",
"destructuredArrayIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"ignoreRestSiblings": true
}
],
"no-useless-backreference": "error",
"use-isnan": [
"error",
{
"enforceForSwitchCase": true,
"enforceForIndexOf": true
}
],
"valid-typeof": [
"error",
{
"requireStringLiterals": true
}
],
"default-param-last": "error",
"default-case-last": "error",
"eqeqeq": [
"error",
"always",
{
"null": "ignore"
}
],
"grouped-accessor-pairs": "error",
"new-cap": [
"error",
{
"newIsCap": true,
"capIsNew": false,
"properties": true
}
],
"no-array-constructor": "error",
"no-caller": "error",
"no-delete-var": "error",
"no-extra-boolean-cast": [
"error",
{
"enforceForInnerExpressions": true
}
],
"no-empty": [
"error",
{
"allowEmptyCatch": true
}
],
"no-empty-static-block": "error",
"no-eval": "error",
"no-global-assign": "error",
"no-multi-str": "error",
"no-new-func": "error",
"no-object-constructor": "error",
"no-proto": "error",
"no-redeclare": [
"error",
{
"builtinGlobals": false
}
],
"no-regex-spaces": "error",
"no-shadow-restricted-names": "error",
"no-throw-literal": "error",
"no-unused-expressions": [
"error",
{
"allowShortCircuit": true,
"allowTernary": true,
"allowTaggedTemplates": true
}
],
"no-useless-call": "error",
"no-useless-concat": "error",
"no-useless-constructor": "error",
"no-useless-escape": "error",
"no-useless-rename": "error",
"no-else-return": [
"error",
{
"allowElseIf": false
}
],
"no-var": "error",
"no-void": [
"error",
{
"allowAsStatement": true
}
],
"no-with": "error",
"prefer-object-has-own": "error",
"prefer-promise-reject-errors": "error",
"radix": "error",
"yoda": ["error", "never"],
"curly": ["error", "all"],
"func-style": ["error", "expression"],
"arrow-body-style": ["error", "always"],
"promise/param-names": "error",
"promise/no-new-statics": "error",
"promise/no-nesting": "error",
"unicorn/catch-error-name": "error",
"unicorn/consistent-date-clone": "error",
"unicorn/error-message": "error",
"unicorn/escape-case": "error",
"unicorn/explicit-length-check": "error",
"unicorn/new-for-builtins": "error",
"unicorn/no-array-for-each": "error",
"unicorn/no-array-method-this-argument": "error",
"unicorn/no-document-cookie": "error",
"unicorn/no-empty-file": "error",
"unicorn/no-hex-escape": "error",
"unicorn/no-instanceof-builtins": "error",
"unicorn/no-new-array": "error",
"unicorn/no-new-buffer": "error",
"unicorn/no-this-assignment": "error",
"unicorn/no-zero-fractions": "error",
"unicorn/number-literal-case": "error",
"unicorn/prefer-node-protocol": "error",
"unicorn/throw-new-error": "error",
"unicorn/no-typeof-undefined": "error",
"unicorn/require-array-join-separator": "error",
"unicorn/prefer-number-properties": "error",
"unicorn/prefer-modern-math-apis": "error",
"unicorn/prefer-structured-clone": "error",
"unicorn/consistent-existence-index-check": "error",
"unicorn/no-unnecessary-array-flat-depth": "error",
"unicorn/consistent-assert": "error",
"unicorn/no-accessor-recursion": "error",
"unicorn/no-array-reverse": "off",
"react/no-array-index-key": "off",
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "error",
"react/jsx-key": "error",
"react/jsx-no-comment-textnodes": "error",
"react/jsx-no-duplicate-props": "error",
"react/jsx-no-target-blank": "off",
"react/jsx-no-undef": "error",
"react/no-children-prop": "error",
"react/no-danger-with-children": "error",
"react/no-direct-mutation-state": "error",
"react/no-find-dom-node": "error",
"react/no-is-mounted": "error",
"react/no-render-return-value": "error",
"react/no-string-refs": "error",
"react/no-unescaped-entities": "error",
"react/no-unknown-property": "off",
"react/react-in-jsx-scope": "off",
"react/iframe-missing-sandbox": "off",
"react/self-closing-comp": [
"error",
{
"component": true,
"html": true
}
],
"react/void-dom-elements-no-children": "error",
"react/jsx-boolean-value": "error",
"@next/next/google-font-display": "error",
"@next/next/google-font-preconnect": "error",
"@next/next/next-script-for-ga": "error",
"@next/next/no-async-client-component": "error",
"@next/next/no-before-interactive-script-outside-document": "error",
"@next/next/no-css-tags": "error",
"@next/next/no-head-element": "error",
"@next/next/no-html-link-for-pages": "off",
"@next/next/no-img-element": "off",
"@next/next/no-page-custom-font": "error",
"@next/next/no-styled-jsx-in-document": "error",
"@next/next/no-sync-scripts": "error",
"@next/next/no-title-in-document-head": "error",
"@next/next/no-typos": "error",
"@next/next/no-unwanted-polyfillio": "error",
"@next/next/inline-script-id": "error",
"@next/next/no-assign-module-variable": "error",
"@next/next/no-document-import-in-page": "error",
"@next/next/no-duplicate-head": "error",
"@next/next/no-head-import-in-document": "error",
"@next/next/no-script-component-in-head": "error"
},
"overrides": [
{
"files": ["**/*.ts", "**/*.tsx"],
"rules": {
"@typescript-eslint/no-unnecessary-type-arguments": "off",
"no-unused-vars": [
"error",
{
"args": "all",
"argsIgnorePattern": "^_",
"caughtErrors": "all",
"caughtErrorsIgnorePattern": "^_",
"destructuredArrayIgnorePattern": "^_",
"varsIgnorePattern": "^_",
"ignoreRestSiblings": true
}
],
"@typescript-eslint/no-implied-eval": "error",
"no-redeclare": [
"error",
{
"builtinGlobals": false
}
],
"no-throw-literal": "off",
"@typescript-eslint/only-throw-error": "error",
"no-unused-expressions": [
"error",
{
"allowShortCircuit": true,
"allowTernary": true,
"allowTaggedTemplates": true
}
],
"@typescript-eslint/no-unnecessary-template-expression": "error",
"@typescript-eslint/adjacent-overload-signatures": "error",
"@typescript-eslint/no-unsafe-function-type": "error",
"@typescript-eslint/no-wrapper-object-types": "error",
"@typescript-eslint/consistent-type-definitions": [
"error",
"interface"
],
"no-duplicate-imports": "off",
"@typescript-eslint/consistent-type-imports": "error",
"@typescript-eslint/explicit-function-return-type": [
"error",
{
"allowExpressions": true,
"allowHigherOrderFunctions": true,
"allowTypedFunctionExpressions": true,
"allowDirectConstAssertionInArrowFunctions": true
}
],
"@typescript-eslint/no-base-to-string": "error",
"@typescript-eslint/no-dynamic-delete": "off",
"@typescript-eslint/no-extra-non-null-assertion": "error",
"@typescript-eslint/no-redundant-type-constituents": "error",
"@typescript-eslint/no-extraneous-class": [
"error",
{
"allowWithDecorator": true
}
],
"@typescript-eslint/no-floating-promises": [
"error",
{
"allowForKnownSafeCalls": [
{
"from": "package",
"name": ["test", "it", "suite", "describe"],
"package": "node:test"
}
]
}
],
"@typescript-eslint/no-for-in-array": "error",
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-non-null-asserted-optional-chain": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"@typescript-eslint/no-this-alias": [
"error",
{
"allowDestructuring": true
}
],
"@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
"@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/no-unsafe-unary-minus": "error",
"@typescript-eslint/no-unsafe-declaration-merging": "error",
"@typescript-eslint/no-array-delete": "error",
"@typescript-eslint/prefer-as-const": "error",
"@typescript-eslint/prefer-function-type": "error",
"@typescript-eslint/prefer-reduce-type-parameter": "error",
"@typescript-eslint/prefer-return-this-type": "error",
"@typescript-eslint/promise-function-async": "error",
"prefer-promise-reject-errors": "off",
"@typescript-eslint/prefer-promise-reject-errors": "error",
"@typescript-eslint/require-array-sort-compare": [
"error",
{
"ignoreStringArrays": true
}
],
"@typescript-eslint/restrict-plus-operands": [
"error",
{
"skipCompoundAssignments": true
}
],
"@typescript-eslint/restrict-template-expressions": [
"error",
{
"allowNumber": true
}
]
},
"plugins": ["typescript"]
}
]
}

View File

@@ -1,6 +1,6 @@
# 💡 Contributing
# Contributing
Thanks a lot for your interest in contributing to **eslint-config-conventions**! 🎉
Thanks a lot for your interest in contributing to **eslint-config-conventions**!
## Code of Conduct

View File

@@ -17,7 +17,7 @@
<a href="https://www.npmjs.com/package/eslint-config-conventions"><img src="https://img.shields.io/npm/v/eslint-config-conventions.svg" alt="npm version"></a>
</p>
## 📜 About
## About
**eslint-config-conventions** is a [ESLint](https://eslint.org) configuration to enforce strict conventions and good code quality. It supports both **JavaScript** and **TypeScript**.
@@ -25,7 +25,7 @@ This configuration is mostly **for catching bugs** and **code-quality** so it is
More information about **formatting rules** vs **code-quality rules** can be found on [Prettier vs. Linters](https://prettier.io/docs/en/comparison.html).
## ⚙️ Getting Started
## Getting Started
### Prerequisites
@@ -35,13 +35,13 @@ More information about **formatting rules** vs **code-quality rules** can be fou
```sh
npm install --save-dev \
eslint@^9.21.0 \
eslint@^9.22.0 \
eslint-plugin-promise@^7.2.1 \
eslint-plugin-unicorn@^57.0.0 \
eslint-plugin-unicorn@^61.0.0 \
eslint-plugin-import-x@^4.6.1 \
globals@^16.0.0 \
typescript@^5.7.3 \
typescript-eslint@^8.24.1 \
typescript@^5.8.3 \
typescript-eslint@^8.32.0 \
eslint-config-conventions@latest
```
@@ -62,10 +62,10 @@ Dependencies are:
#### `eslint.config.js`
```js
import typescriptESLint from "typescript-eslint"
import { defineConfig } from "eslint/config"
import configConventions from "eslint-config-conventions"
export default typescriptESLint.config(...configConventions, {
export default defineConfig(...configConventions, {
files: ["**/*.ts", "**/*.tsx"],
languageOptions: {
parser: typescriptESLint.parser,
@@ -113,12 +113,21 @@ node --run lint:eslint -- --fix
node --run lint:prettier
```
## 💡 Contributing
### `.oxlintrc.json` (if using [oxlint](https://oxc.rs/))
```json
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"extends": ["node_modules/eslint-config-conventions/.oxlintrc.json"]
}
```
## Contributing
Anyone can help to improve the project, submit a Feature Request, a bug report or even correct a simple spelling mistake.
The steps to contribute can be found in the [CONTRIBUTING.md](./CONTRIBUTING.md) file.
## 📄 License
## License
[MIT](./LICENSE)

View File

@@ -1,10 +1,11 @@
import importX from "eslint-plugin-import-x"
import promise from "eslint-plugin-promise"
import unicorn from "eslint-plugin-unicorn"
import importX from "eslint-plugin-import-x"
import { defineConfig } from "eslint/config"
import globals from "globals"
import typescriptESLint from "typescript-eslint"
export default typescriptESLint.config(
export default defineConfig(
{
name: "eslint-config-conventions",
plugins: {
@@ -252,6 +253,9 @@ export default typescriptESLint.config(
"unicorn/prefer-structured-clone": "error",
"unicorn/template-indent": "error",
"unicorn/consistent-existence-index-check": "error",
"unicorn/no-unnecessary-array-flat-depth": "error",
"unicorn/consistent-assert": "error",
"unicorn/no-accessor-recursion": "error",
"import-x/no-absolute-path": "error",
"import-x/no-webpack-loader-syntax": "error",
@@ -381,7 +385,6 @@ export default typescriptESLint.config(
"@typescript-eslint/no-base-to-string": "error",
"@typescript-eslint/no-deprecated": "error",
"@typescript-eslint/no-dynamic-delete": "error",
"@typescript-eslint/no-extra-non-null-assertion": "error",
"@typescript-eslint/no-redundant-type-constituents": "error",
@@ -398,7 +401,7 @@ export default typescriptESLint.config(
allowForKnownSafeCalls: [
{
from: "package",
name: ["it", "describe"],
name: ["test", "it", "suite", "describe"],
package: "node:test",
},
],

View File

@@ -1,6 +1,6 @@
import typescriptESLint from "typescript-eslint"
import { defineConfig } from "eslint/config"
import configConventions from "./eslint.config.js"
export default typescriptESLint.config(...configConventions, {
export default defineConfig(...configConventions, {
ignores: ["test/fixtures/*"],
})

8
index.d.ts vendored
View File

@@ -1,7 +1,5 @@
import type typescriptESLint from "typescript-eslint"
import type { defineConfig } from "eslint/config"
declare const eslintConfigConventions: ReturnType<
typeof typescriptESLint.config
>
declare const eslintConfig: ReturnType<typeof defineConfig>
export default eslintConfigConventions
export default eslintConfig

2490
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -27,7 +27,8 @@
"type": "module",
"files": [
"eslint.config.js",
"index.d.ts"
"index.d.ts",
".oxlintrc.json"
],
"publishConfig": {
"access": "public",
@@ -40,29 +41,52 @@
"lint:editorconfig": "editorconfig-checker",
"lint:eslint": "eslint . --max-warnings 0 --config eslint.config.mjs",
"lint:prettier": "prettier . --check",
"oxlint:migrate": "npx @oxlint/migrate@latest eslint.config.js --type-aware",
"inspect": "eslint --inspect-config",
"test": "node --test",
"release": "semantic-release"
},
"peerDependencies": {
"eslint": "^9.21.0",
"eslint": "^9.22.0",
"eslint-plugin-promise": "^7.2.1",
"eslint-plugin-unicorn": "^57.0.0 || ^58.0.0",
"eslint-plugin-unicorn": "^61.0.0",
"eslint-plugin-import-x": "^4.6.1",
"globals": "^16.0.0",
"typescript-eslint": "^8.24.1"
"typescript-eslint": "^8.32.0"
},
"peerDependenciesMeta": {
"eslint": {
"optional": true
},
"eslint-plugin-promise": {
"optional": true
},
"eslint-plugin-unicorn": {
"optional": true
},
"eslint-plugin-import-x": {
"optional": true
},
"globals": {
"optional": true
},
"typescript-eslint": {
"optional": true
}
},
"devDependencies": {
"@types/node": "22.13.13",
"globals": "16.0.0",
"editorconfig-checker": "6.0.1",
"eslint": "9.23.0",
"@types/node": "24.3.1",
"globals": "16.4.0",
"editorconfig-checker": "6.1.0",
"oxlint": "1.15.0",
"@oxlint/migrate": "1.15.0",
"eslint": "9.35.0",
"eslint-plugin-promise": "7.2.1",
"eslint-plugin-unicorn": "58.0.0",
"eslint-plugin-import-x": "4.9.3",
"typescript-eslint": "8.28.0",
"prettier": "3.5.3",
"semantic-release": "24.2.3",
"typescript": "5.8.2"
"eslint-plugin-unicorn": "61.0.2",
"eslint-plugin-import-x": "4.16.1",
"typescript-eslint": "8.43.0",
"prettier": "3.6.2",
"semantic-release": "24.2.8",
"typescript": "5.9.2"
}
}