ci: pin GitHub Actions by commit-hash

Ref: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash

.github/workflows/lint.yml

@@ -10,10 +10,10 @@ jobs:
   lint:
     runs-on: "ubuntu-latest"
     steps:
-      - uses: "actions/checkout@v4.2.2"
+      - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
 
       - name: "Setup Node.js"
-        uses: "actions/setup-node@v4.2.0"
+        uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
         with:
           node-version: "lts/*"
           cache: "npm"
@@ -24,10 +24,3 @@ jobs:
       - run: "node --run lint:editorconfig"
       - run: "node --run lint:eslint"
       - run: "node --run lint:prettier"
-
-  commitlint:
-    runs-on: "ubuntu-latest"
-    steps:
-      - uses: "actions/checkout@v4.2.2"
-
-      - uses: "wagoid/commitlint-github-action@v6.1.2"

.github/workflows/release.yml

@@ -13,13 +13,13 @@ jobs:
       pull-requests: "write"
       id-token: "write"
     steps:
-      - uses: "actions/checkout@v4.2.2"
+      - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
         with:
           fetch-depth: 0
           persist-credentials: false
 
       - name: "Setup Node.js"
-        uses: "actions/setup-node@v4.2.0"
+        uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
         with:
           node-version: "lts/*"
           cache: "npm"

.github/workflows/test.yml

@@ -10,10 +10,10 @@ jobs:
   test:
     runs-on: "ubuntu-latest"
     steps:
-      - uses: "actions/checkout@v4.2.2"
+      - uses: "actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8" # v5.0.0
 
       - name: "Setup Node.js"
-        uses: "actions/setup-node@v4.2.0"
+        uses: "actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903" # v6.0.0
         with:
           node-version: "lts/*"
           cache: "npm"

.oxlintrc.json

@@ -1,18 +1,19 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
-  "plugins": ["promise", "unicorn", "import"],
+  "plugins": ["typescript", "unicorn", "react", "oxc", "import", "promise"],
   "categories": {
-    "correctness": "off"
+    "correctness": "error",
+    "perf": "error",
+    "suspicious": "error"
   },
   "env": {
     "builtin": true,
-    "es2025": true,
     "browser": true,
-    "commonjs": true,
     "node": true,
     "shared-node-browser": true
   },
   "rules": {
+    "no-await-in-loop": "off",
     "for-direction": "error",
     "no-async-promise-executor": "error",
     "no-class-assign": "error",
@@ -136,6 +137,7 @@
     ],
     "no-useless-call": "error",
     "no-useless-concat": "error",
+    "no-useless-computed-key": "error",
     "no-useless-constructor": "error",
     "no-useless-escape": "error",
     "no-useless-rename": "error",
@@ -159,8 +161,10 @@
     "yoda": ["error", "never"],
     "curly": ["error", "all"],
     "func-style": ["error", "expression"],
+    "arrow-body-style": ["error", "always"],
     "promise/param-names": "error",
     "promise/no-new-statics": "error",
+    "promise/no-multiple-resolved": "error",
     "promise/no-nesting": "error",
     "unicorn/catch-error-name": "error",
     "unicorn/consistent-date-clone": "error",
@@ -168,6 +172,7 @@
     "unicorn/escape-case": "error",
     "unicorn/explicit-length-check": "error",
     "unicorn/new-for-builtins": "error",
+    "unicorn/no-array-callback-reference": "error",
     "unicorn/no-array-for-each": "error",
     "unicorn/no-array-method-this-argument": "error",
     "unicorn/no-document-cookie": "error",
@@ -190,6 +195,57 @@
     "unicorn/no-unnecessary-array-flat-depth": "error",
     "unicorn/consistent-assert": "error",
     "unicorn/no-accessor-recursion": "error",
+    "unicorn/no-array-reverse": "off",
+    "unicorn/no-array-sort": "off",
+    "react/no-array-index-key": "off",
+    "react-hooks/rules-of-hooks": "error",
+    "react-hooks/exhaustive-deps": "error",
+    "react/jsx-key": "error",
+    "react/jsx-no-comment-textnodes": "error",
+    "react/jsx-no-duplicate-props": "error",
+    "react/jsx-no-target-blank": "off",
+    "react/jsx-no-undef": "error",
+    "react/no-children-prop": "error",
+    "react/no-danger-with-children": "error",
+    "react/no-direct-mutation-state": "error",
+    "react/no-find-dom-node": "error",
+    "react/no-is-mounted": "error",
+    "react/no-render-return-value": "error",
+    "react/no-string-refs": "error",
+    "react/no-unescaped-entities": "error",
+    "react/no-unknown-property": "off",
+    "react/react-in-jsx-scope": "off",
+    "react/iframe-missing-sandbox": "off",
+    "react/self-closing-comp": [
+      "error",
+      {
+        "component": true,
+        "html": true
+      }
+    ],
+    "react/void-dom-elements-no-children": "error",
+    "react/jsx-boolean-value": "error",
+    "@next/next/google-font-display": "error",
+    "@next/next/google-font-preconnect": "error",
+    "@next/next/next-script-for-ga": "error",
+    "@next/next/no-async-client-component": "error",
+    "@next/next/no-before-interactive-script-outside-document": "error",
+    "@next/next/no-css-tags": "error",
+    "@next/next/no-head-element": "error",
+    "@next/next/no-html-link-for-pages": "off",
+    "@next/next/no-img-element": "off",
+    "@next/next/no-page-custom-font": "error",
+    "@next/next/no-styled-jsx-in-document": "error",
+    "@next/next/no-sync-scripts": "error",
+    "@next/next/no-title-in-document-head": "error",
+    "@next/next/no-typos": "error",
+    "@next/next/no-unwanted-polyfillio": "error",
+    "@next/next/inline-script-id": "error",
+    "@next/next/no-assign-module-variable": "error",
+    "@next/next/no-document-import-in-page": "error",
+    "@next/next/no-duplicate-head": "error",
+    "@next/next/no-head-import-in-document": "error",
+    "@next/next/no-script-component-in-head": "error",
     "import-x/no-absolute-path": "error",
     "import-x/no-webpack-loader-syntax": "error",
     "import-x/no-self-import": "error",
@@ -197,12 +253,16 @@
     "import-x/no-named-default": "error",
     "import-x/no-empty-named-blocks": "error",
     "import-x/no-anonymous-default-export": "error",
-    "import-x/consistent-type-specifier-style": ["error", "prefer-top-level"]
+    "import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
+    "import-x/no-unassigned-import": "off",
+    "import-x/no-named-as-default-member": "off"
   },
   "overrides": [
     {
       "files": ["**/*.ts", "**/*.tsx"],
       "rules": {
+        "@typescript-eslint/no-unnecessary-type-arguments": "off",
+        "@typescript-eslint/no-unsafe-type-assertion": "off",
         "no-unused-vars": [
           "error",
           {
@@ -215,6 +275,7 @@
             "ignoreRestSiblings": true
           }
         ],
+        "@typescript-eslint/no-implied-eval": "error",
         "no-redeclare": [
           "error",
           {
@@ -222,6 +283,7 @@
           }
         ],
         "no-throw-literal": "off",
+        "@typescript-eslint/only-throw-error": "error",
         "no-unused-expressions": [
           "error",
           {
@@ -230,6 +292,7 @@
             "allowTaggedTemplates": true
           }
         ],
+        "@typescript-eslint/no-unnecessary-template-expression": "error",
         "@typescript-eslint/adjacent-overload-signatures": "error",
         "@typescript-eslint/no-unsafe-function-type": "error",
         "@typescript-eslint/no-wrapper-object-types": "error",
@@ -248,14 +311,29 @@
             "allowDirectConstAssertionInArrowFunctions": true
           }
         ],
-        "@typescript-eslint/no-dynamic-delete": "error",
+        "@typescript-eslint/no-base-to-string": "error",
+        "@typescript-eslint/no-dynamic-delete": "off",
         "@typescript-eslint/no-extra-non-null-assertion": "error",
+        "@typescript-eslint/no-redundant-type-constituents": "error",
         "@typescript-eslint/no-extraneous-class": [
           "error",
           {
             "allowWithDecorator": true
           }
         ],
+        "@typescript-eslint/no-floating-promises": [
+          "error",
+          {
+            "allowForKnownSafeCalls": [
+              {
+                "from": "package",
+                "name": ["test", "it", "suite", "describe"],
+                "package": "node:test"
+              }
+            ]
+          }
+        ],
+        "@typescript-eslint/no-for-in-array": "error",
         "@typescript-eslint/no-misused-new": "error",
         "@typescript-eslint/no-non-null-asserted-optional-chain": "error",
         "@typescript-eslint/no-non-null-assertion": "error",
@@ -265,11 +343,37 @@
             "allowDestructuring": true
           }
         ],
+        "@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
+        "@typescript-eslint/no-unnecessary-type-assertion": "error",
         "@typescript-eslint/no-require-imports": "error",
+        "@typescript-eslint/no-unsafe-unary-minus": "error",
         "@typescript-eslint/no-unsafe-declaration-merging": "error",
+        "@typescript-eslint/no-array-delete": "error",
         "@typescript-eslint/prefer-as-const": "error",
         "@typescript-eslint/prefer-function-type": "error",
-        "prefer-promise-reject-errors": "off"
+        "@typescript-eslint/prefer-reduce-type-parameter": "error",
+        "@typescript-eslint/prefer-return-this-type": "error",
+        "@typescript-eslint/promise-function-async": "error",
+        "prefer-promise-reject-errors": "off",
+        "@typescript-eslint/prefer-promise-reject-errors": "error",
+        "@typescript-eslint/require-array-sort-compare": [
+          "error",
+          {
+            "ignoreStringArrays": true
+          }
+        ],
+        "@typescript-eslint/restrict-plus-operands": [
+          "error",
+          {
+            "skipCompoundAssignments": true
+          }
+        ],
+        "@typescript-eslint/restrict-template-expressions": [
+          "error",
+          {
+            "allowNumber": true
+          }
+        ]
       },
       "plugins": ["typescript"]
     }

CONTRIBUTING.md

@@ -1,6 +1,6 @@
-# 💡 Contributing
+# Contributing
 
-Thanks a lot for your interest in contributing to **eslint-config-conventions**! 🎉
+Thanks a lot for your interest in contributing to **eslint-config-conventions**!
 
 ## Code of Conduct
 

README.md

@@ -17,7 +17,7 @@
   <a href="https://www.npmjs.com/package/eslint-config-conventions"><img src="https://img.shields.io/npm/v/eslint-config-conventions.svg" alt="npm version"></a>
 </p>
 
-## 📜 About
+## About
 
 **eslint-config-conventions** is a [ESLint](https://eslint.org) configuration to enforce strict conventions and good code quality. It supports both **JavaScript** and **TypeScript**.
 
@@ -25,7 +25,7 @@ This configuration is mostly **for catching bugs** and **code-quality** so it is
 
 More information about **formatting rules** vs **code-quality rules** can be found on [Prettier vs. Linters](https://prettier.io/docs/en/comparison.html).
 
-## ⚙️ Getting Started
+## Getting Started
 
 ### Prerequisites
 
@@ -35,12 +35,12 @@ More information about **formatting rules** vs **code-quality rules** can be fou
 
 ```sh
 npm install --save-dev \
-  eslint@^9.21.0 \
+  eslint@^9.22.0 \
   eslint-plugin-promise@^7.2.1 \
-  eslint-plugin-unicorn@^59.0.0 \
+  eslint-plugin-unicorn@^62.0.0 \
   eslint-plugin-import-x@^4.6.1 \
   globals@^16.0.0 \
-  typescript@^5.8.3 \
+  typescript@^5.9.3 \
   typescript-eslint@^8.32.0 \
   eslint-config-conventions@latest
 ```
@@ -62,10 +62,10 @@ Dependencies are:
 #### `eslint.config.js`
 
 ```js
-import typescriptESLint from "typescript-eslint"
+import { defineConfig } from "eslint/config"
 import configConventions from "eslint-config-conventions"
 
-export default typescriptESLint.config(...configConventions, {
+export default defineConfig(...configConventions, {
   files: ["**/*.ts", "**/*.tsx"],
   languageOptions: {
     parser: typescriptESLint.parser,
@@ -113,12 +113,21 @@ node --run lint:eslint -- --fix
 node --run lint:prettier
 ```
 
-## 💡 Contributing
+### `.oxlintrc.json` (if using [oxlint](https://oxc.rs/))
+
+```json
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "extends": ["node_modules/eslint-config-conventions/.oxlintrc.json"]
+}
+```
+
+## Contributing
 
 Anyone can help to improve the project, submit a Feature Request, a bug report or even correct a simple spelling mistake.
 
 The steps to contribute can be found in the [CONTRIBUTING.md](./CONTRIBUTING.md) file.
 
-## 📄 License
+## License
 
 [MIT](./LICENSE)

eslint.config.js

@@ -1,16 +1,17 @@
+import importXPlugin from "eslint-plugin-import-x"
 import promise from "eslint-plugin-promise"
 import unicorn from "eslint-plugin-unicorn"
-import importX from "eslint-plugin-import-x"
+import { defineConfig } from "eslint/config"
 import globals from "globals"
 import typescriptESLint from "typescript-eslint"
 
-export default typescriptESLint.config(
+export default defineConfig(
   {
     name: "eslint-config-conventions",
     plugins: {
       promise,
       unicorn,
-      "import-x": importX,
+      "import-x": importXPlugin,
     },
     linterOptions: {
       reportUnusedDisableDirectives: "error",
@@ -349,8 +350,6 @@ export default typescriptESLint.config(
       "no-useless-constructor": "off",
       "@typescript-eslint/no-useless-constructor": "error",
 
-      "@typescript-eslint/no-unnecessary-type-conversion": "error",
-
       "@typescript-eslint/no-unnecessary-template-expression": "error",
       "@typescript-eslint/adjacent-overload-signatures": "error",
 
@@ -386,7 +385,6 @@ export default typescriptESLint.config(
 
       "@typescript-eslint/no-base-to-string": "error",
       "@typescript-eslint/no-deprecated": "error",
-      "@typescript-eslint/no-dynamic-delete": "error",
       "@typescript-eslint/no-extra-non-null-assertion": "error",
       "@typescript-eslint/no-redundant-type-constituents": "error",
 
@@ -403,7 +401,7 @@ export default typescriptESLint.config(
           allowForKnownSafeCalls: [
             {
               from: "package",
-              name: ["it", "describe"],
+              name: ["test", "it", "suite", "describe"],
               package: "node:test",
             },
           ],

eslint.config.mjs

@@ -1,6 +1,6 @@
-import typescriptESLint from "typescript-eslint"
+import { defineConfig } from "eslint/config"
 import configConventions from "./eslint.config.js"
 
-export default typescriptESLint.config(...configConventions, {
+export default defineConfig(...configConventions, {
   ignores: ["test/fixtures/*"],
 })

index.d.ts

@@ -1,7 +1,5 @@
-import type typescriptESLint from "typescript-eslint"
+import type { defineConfig } from "eslint/config"
 
-declare const eslintConfigConventions: ReturnType<
+declare const eslintConfig: ReturnType<typeof defineConfig>
-  typeof typescriptESLint.config
->
 
-export default eslintConfigConventions
+export default eslintConfig

package.json

@@ -41,32 +41,52 @@
     "lint:editorconfig": "editorconfig-checker",
     "lint:eslint": "eslint . --max-warnings 0 --config eslint.config.mjs",
     "lint:prettier": "prettier . --check",
-    "oxlint:migrate": "npx @oxlint/migrate",
+    "oxlint:migrate": "npx @oxlint/migrate@latest eslint.config.js --type-aware",
     "inspect": "eslint --inspect-config",
     "test": "node --test",
     "release": "semantic-release"
   },
   "peerDependencies": {
-    "eslint": "^9.21.0",
+    "eslint": "^9.22.0",
     "eslint-plugin-promise": "^7.2.1",
-    "eslint-plugin-unicorn": "^59.0.0 || ^60.0.0",
+    "eslint-plugin-unicorn": "^61.0.0 || ^62.0.0",
     "eslint-plugin-import-x": "^4.6.1",
     "globals": "^16.0.0",
     "typescript-eslint": "^8.32.0"
   },
+  "peerDependenciesMeta": {
+    "eslint": {
+      "optional": true
+    },
+    "eslint-plugin-promise": {
+      "optional": true
+    },
+    "eslint-plugin-unicorn": {
+      "optional": true
+    },
+    "eslint-plugin-import-x": {
+      "optional": true
+    },
+    "globals": {
+      "optional": true
+    },
+    "typescript-eslint": {
+      "optional": true
+    }
+  },
   "devDependencies": {
-    "@types/node": "24.0.15",
+    "@types/node": "24.9.1",
-    "globals": "16.3.0",
+    "globals": "16.4.0",
-    "editorconfig-checker": "6.1.0",
+    "editorconfig-checker": "6.1.1",
-    "oxlint": "1.7.0",
+    "oxlint": "1.24.0",
-    "@oxlint/migrate": "1.7.0",
+    "@oxlint/migrate": "1.24.0",
-    "eslint": "9.31.0",
+    "eslint": "9.38.0",
     "eslint-plugin-promise": "7.2.1",
-    "eslint-plugin-unicorn": "60.0.0",
+    "eslint-plugin-unicorn": "62.0.0",
     "eslint-plugin-import-x": "4.16.1",
-    "typescript-eslint": "8.38.0",
+    "typescript-eslint": "8.46.2",
     "prettier": "3.6.2",
-    "semantic-release": "24.2.7",
+    "semantic-release": "25.0.1",
-    "typescript": "5.8.3"
+    "typescript": "5.9.3"
   }
 }