1
0
mirror of https://github.com/theoludwig/eslint-config-conventions.git synced 2026-01-17 23:15:13 +01:00

Compare commits

..

23 Commits

Author SHA1 Message Date
ce4c314fa5 ci: trusted npm package publishing (OIDC)
Ref: https://docs.npmjs.com/trusted-publishers
2026-01-14 23:36:26 +01:00
9cc2cd435c fix: update .oxlintrc.json 2026-01-14 23:18:33 +01:00
10f63cedae feat: support globals@^17.0.0 2026-01-14 23:17:56 +01:00
1ca98dd3cb build(deps): update latest 2026-01-14 23:17:34 +01:00
f3eae972a5 fix: update .oxlintrc.json 2025-11-27 12:07:31 +01:00
0bcd75514b fix: relax @typescript-eslint/only-throw-error 2025-11-27 12:01:09 +01:00
7a98b2fe8c fix: relax @typescript-eslint/no-redundant-type-constituents 2025-11-27 11:59:15 +01:00
d6ba808207 build(deps): update latest 2025-11-27 11:58:20 +01:00
ede428ba5f ci: pin GitHub Actions by commit-hash
Ref: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
2025-11-01 00:51:39 +01:00
977745dabb fix: update .oxlintrc.json 2025-10-26 15:37:34 +01:00
54392498cf feat: support eslint-plugin-unicorn@^62.0.0 2025-10-26 15:32:53 +01:00
e59d48f713 build(deps): update latest 2025-10-08 17:00:11 +02:00
b2f5a136f9 fix(oxlint): relax unicorn/no-array-sort 2025-10-04 19:17:18 +02:00
fa724b4f97 fix(oxlint): relax import-x/no-named-as-default-member 2025-10-04 19:16:10 +02:00
1b70b62de1 fix(oxlint): relax import-x/no-unassigned-import 2025-09-26 19:59:58 +02:00
09493ef433 fix(oxlint): relax @typescript-eslint/no-unsafe-type-assertion 2025-09-25 07:59:20 +02:00
a13aeadda8 fix(oxlint): enable back import rules
Ref: https://github.com/oxc-project/oxc/pull/14049
2025-09-25 07:58:02 +02:00
5817503919 fix: update .oxlintrc.json 2025-09-11 21:06:08 +02:00
23bb31949d fix: relax @typescript-eslint/no-dynamic-delete 2025-09-11 21:00:36 +02:00
911fadcf02 fix: relax @typescript-eslint/no-unnecessary-type-conversion 2025-09-11 20:57:39 +02:00
2d8260472a fix!: usage of eslint defineConfig()
Ref: https://typescript-eslint.io/packages/typescript-eslint/#migrating-to-defineconfig

BREAKING CHANGE: peerDependencies:
`eslint@^9.22.0`
`eslint-plugin-unicorn@^61.0.0`
2025-09-11 19:48:20 +02:00
929978af36 feat: support eslint-plugin-unicorn@^61.0.0 2025-09-08 08:27:35 +02:00
6f42dbcdbe fix: relax jsx-a11y rules in .oxlintrc.json 2025-08-28 12:41:17 +02:00
10 changed files with 1820 additions and 2012 deletions

View File

@@ -10,10 +10,10 @@ jobs:
lint: lint:
runs-on: "ubuntu-latest" runs-on: "ubuntu-latest"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v6.0.1
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f" # v6.1.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"

View File

@@ -4,6 +4,10 @@ on:
push: push:
branches: [main, beta] branches: [main, beta]
permissions:
id-token: "write" # OIDC
contents: "read"
jobs: jobs:
release: release:
runs-on: "ubuntu-latest" runs-on: "ubuntu-latest"
@@ -13,13 +17,13 @@ jobs:
pull-requests: "write" pull-requests: "write"
id-token: "write" id-token: "write"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v6.0.1
with: with:
fetch-depth: 0 fetch-depth: 0
persist-credentials: false persist-credentials: false
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f" # v6.1.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"
@@ -34,4 +38,3 @@ jobs:
run: "node --run release" run: "node --run release"
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

View File

@@ -10,10 +10,10 @@ jobs:
test: test:
runs-on: "ubuntu-latest" runs-on: "ubuntu-latest"
steps: steps:
- uses: "actions/checkout@v4.2.2" - uses: "actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8" # v6.0.1
- name: "Setup Node.js" - name: "Setup Node.js"
uses: "actions/setup-node@v4.2.0" uses: "actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f" # v6.1.0
with: with:
node-version: "lts/*" node-version: "lts/*"
cache: "npm" cache: "npm"

View File

@@ -1,6 +1,6 @@
{ {
"$schema": "./node_modules/oxlint/configuration_schema.json", "$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["typescript", "unicorn", "react", "oxc", "jsx-a11y", "promise"], "plugins": ["typescript", "unicorn", "react", "oxc", "import", "promise"],
"categories": { "categories": {
"correctness": "error", "correctness": "error",
"perf": "error", "perf": "error",
@@ -14,6 +14,7 @@
}, },
"rules": { "rules": {
"no-await-in-loop": "off", "no-await-in-loop": "off",
"constructor-super": "error",
"for-direction": "error", "for-direction": "error",
"no-async-promise-executor": "error", "no-async-promise-executor": "error",
"no-class-assign": "error", "no-class-assign": "error",
@@ -41,6 +42,7 @@
"no-loss-of-precision": "error", "no-loss-of-precision": "error",
"no-new-native-nonconstructor": "error", "no-new-native-nonconstructor": "error",
"no-obj-calls": "error", "no-obj-calls": "error",
"no-promise-executor-return": "error",
"no-prototype-builtins": "error", "no-prototype-builtins": "error",
"no-self-assign": "error", "no-self-assign": "error",
"no-self-compare": "error", "no-self-compare": "error",
@@ -99,6 +101,7 @@
"no-array-constructor": "error", "no-array-constructor": "error",
"no-caller": "error", "no-caller": "error",
"no-delete-var": "error", "no-delete-var": "error",
"no-implicit-coercion": "error",
"no-extra-boolean-cast": [ "no-extra-boolean-cast": [
"error", "error",
{ {
@@ -126,7 +129,7 @@
], ],
"no-regex-spaces": "error", "no-regex-spaces": "error",
"no-shadow-restricted-names": "error", "no-shadow-restricted-names": "error",
"no-throw-literal": "error", "no-throw-literal": "off",
"no-unused-expressions": [ "no-unused-expressions": [
"error", "error",
{ {
@@ -137,9 +140,11 @@
], ],
"no-useless-call": "error", "no-useless-call": "error",
"no-useless-concat": "error", "no-useless-concat": "error",
"no-useless-computed-key": "error",
"no-useless-constructor": "error", "no-useless-constructor": "error",
"no-useless-escape": "error", "no-useless-escape": "error",
"no-useless-rename": "error", "no-useless-rename": "error",
"no-useless-return": "error",
"no-else-return": [ "no-else-return": [
"error", "error",
{ {
@@ -163,6 +168,7 @@
"arrow-body-style": ["error", "always"], "arrow-body-style": ["error", "always"],
"promise/param-names": "error", "promise/param-names": "error",
"promise/no-new-statics": "error", "promise/no-new-statics": "error",
"promise/no-multiple-resolved": "error",
"promise/no-nesting": "error", "promise/no-nesting": "error",
"unicorn/catch-error-name": "error", "unicorn/catch-error-name": "error",
"unicorn/consistent-date-clone": "error", "unicorn/consistent-date-clone": "error",
@@ -170,6 +176,7 @@
"unicorn/escape-case": "error", "unicorn/escape-case": "error",
"unicorn/explicit-length-check": "error", "unicorn/explicit-length-check": "error",
"unicorn/new-for-builtins": "error", "unicorn/new-for-builtins": "error",
"unicorn/no-array-callback-reference": "error",
"unicorn/no-array-for-each": "error", "unicorn/no-array-for-each": "error",
"unicorn/no-array-method-this-argument": "error", "unicorn/no-array-method-this-argument": "error",
"unicorn/no-document-cookie": "error", "unicorn/no-document-cookie": "error",
@@ -192,6 +199,9 @@
"unicorn/no-unnecessary-array-flat-depth": "error", "unicorn/no-unnecessary-array-flat-depth": "error",
"unicorn/consistent-assert": "error", "unicorn/consistent-assert": "error",
"unicorn/no-accessor-recursion": "error", "unicorn/no-accessor-recursion": "error",
"unicorn/no-array-reverse": "off",
"unicorn/no-array-sort": "off",
"react/no-array-index-key": "off",
"react-hooks/rules-of-hooks": "error", "react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "error", "react-hooks/exhaustive-deps": "error",
"react/jsx-key": "error", "react/jsx-key": "error",
@@ -239,13 +249,24 @@
"@next/next/no-document-import-in-page": "error", "@next/next/no-document-import-in-page": "error",
"@next/next/no-duplicate-head": "error", "@next/next/no-duplicate-head": "error",
"@next/next/no-head-import-in-document": "error", "@next/next/no-head-import-in-document": "error",
"@next/next/no-script-component-in-head": "error" "@next/next/no-script-component-in-head": "error",
"import-x/no-absolute-path": "error",
"import-x/no-webpack-loader-syntax": "error",
"import-x/no-self-import": "error",
"import-x/no-duplicates": "error",
"import-x/no-named-default": "error",
"import-x/no-empty-named-blocks": "error",
"import-x/no-anonymous-default-export": "error",
"import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
"import-x/no-unassigned-import": "off",
"import-x/no-named-as-default-member": "off"
}, },
"overrides": [ "overrides": [
{ {
"files": ["**/*.ts", "**/*.tsx"], "files": ["**/*.ts", "**/*.tsx"],
"rules": { "rules": {
"@typescript-eslint/no-unnecessary-type-arguments": "off", "@typescript-eslint/no-unnecessary-type-arguments": "off",
"@typescript-eslint/no-unsafe-type-assertion": "off",
"no-unused-vars": [ "no-unused-vars": [
"error", "error",
{ {
@@ -265,8 +286,7 @@
"builtinGlobals": false "builtinGlobals": false
} }
], ],
"no-throw-literal": "off", "@typescript-eslint/only-throw-error": "off",
"@typescript-eslint/only-throw-error": "error",
"no-unused-expressions": [ "no-unused-expressions": [
"error", "error",
{ {
@@ -295,7 +315,8 @@
} }
], ],
"@typescript-eslint/no-base-to-string": "error", "@typescript-eslint/no-base-to-string": "error",
"@typescript-eslint/no-dynamic-delete": "error", "@typescript-eslint/no-dynamic-delete": "off",
"@typescript-eslint/no-deprecated": "off",
"@typescript-eslint/no-extra-non-null-assertion": "error", "@typescript-eslint/no-extra-non-null-assertion": "error",
"@typescript-eslint/no-redundant-type-constituents": "error", "@typescript-eslint/no-redundant-type-constituents": "error",
"@typescript-eslint/no-extraneous-class": [ "@typescript-eslint/no-extraneous-class": [
@@ -334,6 +355,15 @@
"@typescript-eslint/no-array-delete": "error", "@typescript-eslint/no-array-delete": "error",
"@typescript-eslint/prefer-as-const": "error", "@typescript-eslint/prefer-as-const": "error",
"@typescript-eslint/prefer-function-type": "error", "@typescript-eslint/prefer-function-type": "error",
"@typescript-eslint/prefer-includes": "error",
"@typescript-eslint/prefer-nullish-coalescing": [
"error",
{
"ignoreTernaryTests": true,
"ignoreConditionalTests": false,
"ignoreMixedLogicalExpressions": false
}
],
"@typescript-eslint/prefer-reduce-type-parameter": "error", "@typescript-eslint/prefer-reduce-type-parameter": "error",
"@typescript-eslint/prefer-return-this-type": "error", "@typescript-eslint/prefer-return-this-type": "error",
"@typescript-eslint/promise-function-async": "error", "@typescript-eslint/promise-function-async": "error",
@@ -356,6 +386,18 @@
{ {
"allowNumber": true "allowNumber": true
} }
],
"@typescript-eslint/strict-boolean-expressions": [
"error",
{
"allowString": false,
"allowNumber": false,
"allowNullableObject": false,
"allowNullableBoolean": false,
"allowNullableString": false,
"allowNullableNumber": false,
"allowAny": false
}
] ]
}, },
"plugins": ["typescript"] "plugins": ["typescript"]

View File

@@ -35,12 +35,12 @@ More information about **formatting rules** vs **code-quality rules** can be fou
```sh ```sh
npm install --save-dev \ npm install --save-dev \
eslint@^9.21.0 \ eslint@^9.22.0 \
eslint-plugin-promise@^7.2.1 \ eslint-plugin-promise@^7.2.1 \
eslint-plugin-unicorn@^59.0.0 \ eslint-plugin-unicorn@^62.0.0 \
eslint-plugin-import-x@^4.6.1 \ eslint-plugin-import-x@^4.6.1 \
globals@^16.0.0 \ globals@^17.0.0 \
typescript@^5.8.3 \ typescript@^5.9.3 \
typescript-eslint@^8.32.0 \ typescript-eslint@^8.32.0 \
eslint-config-conventions@latest eslint-config-conventions@latest
``` ```
@@ -62,10 +62,10 @@ Dependencies are:
#### `eslint.config.js` #### `eslint.config.js`
```js ```js
import typescriptESLint from "typescript-eslint" import { defineConfig } from "eslint/config"
import configConventions from "eslint-config-conventions" import configConventions from "eslint-config-conventions"
export default typescriptESLint.config(...configConventions, { export default defineConfig(...configConventions, {
files: ["**/*.ts", "**/*.tsx"], files: ["**/*.ts", "**/*.tsx"],
languageOptions: { languageOptions: {
parser: typescriptESLint.parser, parser: typescriptESLint.parser,

View File

@@ -1,16 +1,17 @@
import importXPlugin from "eslint-plugin-import-x"
import promise from "eslint-plugin-promise" import promise from "eslint-plugin-promise"
import unicorn from "eslint-plugin-unicorn" import unicorn from "eslint-plugin-unicorn"
import importX from "eslint-plugin-import-x" import { defineConfig } from "eslint/config"
import globals from "globals" import globals from "globals"
import typescriptESLint from "typescript-eslint" import typescriptESLint from "typescript-eslint"
export default typescriptESLint.config( export default defineConfig(
{ {
name: "eslint-config-conventions", name: "eslint-config-conventions",
plugins: { plugins: {
promise, promise,
unicorn, unicorn,
"import-x": importX, "import-x": importXPlugin,
}, },
linterOptions: { linterOptions: {
reportUnusedDisableDirectives: "error", reportUnusedDisableDirectives: "error",
@@ -158,7 +159,7 @@ export default typescriptESLint.config(
], ],
"no-regex-spaces": "error", "no-regex-spaces": "error",
"no-shadow-restricted-names": "error", "no-shadow-restricted-names": "error",
"no-throw-literal": "error", "no-throw-literal": "off",
"no-undef-init": "error", "no-undef-init": "error",
"no-unused-expressions": [ "no-unused-expressions": [
"error", "error",
@@ -334,7 +335,7 @@ export default typescriptESLint.config(
], ],
"no-throw-literal": "off", "no-throw-literal": "off",
"@typescript-eslint/only-throw-error": "error", "@typescript-eslint/only-throw-error": "off",
"no-unused-expressions": "off", "no-unused-expressions": "off",
"@typescript-eslint/no-unused-expressions": [ "@typescript-eslint/no-unused-expressions": [
@@ -349,8 +350,6 @@ export default typescriptESLint.config(
"no-useless-constructor": "off", "no-useless-constructor": "off",
"@typescript-eslint/no-useless-constructor": "error", "@typescript-eslint/no-useless-constructor": "error",
"@typescript-eslint/no-unnecessary-type-conversion": "error",
"@typescript-eslint/no-unnecessary-template-expression": "error", "@typescript-eslint/no-unnecessary-template-expression": "error",
"@typescript-eslint/adjacent-overload-signatures": "error", "@typescript-eslint/adjacent-overload-signatures": "error",
@@ -386,9 +385,8 @@ export default typescriptESLint.config(
"@typescript-eslint/no-base-to-string": "error", "@typescript-eslint/no-base-to-string": "error",
"@typescript-eslint/no-deprecated": "error", "@typescript-eslint/no-deprecated": "error",
"@typescript-eslint/no-dynamic-delete": "error",
"@typescript-eslint/no-extra-non-null-assertion": "error", "@typescript-eslint/no-extra-non-null-assertion": "error",
"@typescript-eslint/no-redundant-type-constituents": "error", "@typescript-eslint/no-redundant-type-constituents": "off",
"@typescript-eslint/no-extraneous-class": [ "@typescript-eslint/no-extraneous-class": [
"error", "error",

View File

@@ -1,6 +1,6 @@
import typescriptESLint from "typescript-eslint" import { defineConfig } from "eslint/config"
import configConventions from "./eslint.config.js" import configConventions from "./eslint.config.js"
export default typescriptESLint.config(...configConventions, { export default defineConfig(...configConventions, {
ignores: ["test/fixtures/*"], ignores: ["test/fixtures/*"],
}) })

8
index.d.ts vendored
View File

@@ -1,7 +1,5 @@
import type typescriptESLint from "typescript-eslint" import type { defineConfig } from "eslint/config"
declare const eslintConfigConventions: ReturnType< declare const eslintConfig: ReturnType<typeof defineConfig>
typeof typescriptESLint.config
>
export default eslintConfigConventions export default eslintConfig

3693
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -47,11 +47,11 @@
"release": "semantic-release" "release": "semantic-release"
}, },
"peerDependencies": { "peerDependencies": {
"eslint": "^9.21.0", "eslint": "^9.22.0",
"eslint-plugin-promise": "^7.2.1", "eslint-plugin-promise": "^7.2.1",
"eslint-plugin-unicorn": "^59.0.0 || ^60.0.0", "eslint-plugin-unicorn": "^61.0.0 || ^62.0.0",
"eslint-plugin-import-x": "^4.6.1", "eslint-plugin-import-x": "^4.6.1",
"globals": "^16.0.0", "globals": "^16.0.0 || ^17.0.0",
"typescript-eslint": "^8.32.0" "typescript-eslint": "^8.32.0"
}, },
"peerDependenciesMeta": { "peerDependenciesMeta": {
@@ -75,18 +75,18 @@
} }
}, },
"devDependencies": { "devDependencies": {
"@types/node": "24.3.0", "@types/node": "25.0.8",
"globals": "16.3.0", "globals": "17.0.0",
"editorconfig-checker": "6.1.0", "editorconfig-checker": "6.1.1",
"oxlint": "1.13.0", "oxlint": "1.39.0",
"@oxlint/migrate": "1.13.0", "@oxlint/migrate": "1.39.0",
"eslint": "9.34.0", "eslint": "9.39.2",
"eslint-plugin-promise": "7.2.1", "eslint-plugin-promise": "7.2.1",
"eslint-plugin-unicorn": "60.0.0", "eslint-plugin-unicorn": "62.0.0",
"eslint-plugin-import-x": "4.16.1", "eslint-plugin-import-x": "4.16.1",
"typescript-eslint": "8.41.0", "typescript-eslint": "8.53.0",
"prettier": "3.6.2", "prettier": "3.7.4",
"semantic-release": "24.2.7", "semantic-release": "25.0.2",
"typescript": "5.9.2" "typescript": "5.9.3"
} }
} }